Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #2895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #2895

wants to merge 1 commit into from

Conversation

Bajkowsky
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Dec 16, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task! 🎉 The code meets the core requirements and functions as expected. Just make sure to update the user property mapping in initialTodos to use todo.userId instead of todo.id for correct user association. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/App.tsx

const initialTodos: Todo[] = todosFromServer.map(todo => ({
...todo,
user: getUserById(todo.id),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user property is being assigned using getUserById(todo.id), but it should use todo.userId to correctly associate the user with the todo item. Change this to getUserById(todo.userId).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bajkowsky @mateacademy-ai-mentor