Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #2918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add solution #2918

wants to merge 1 commit into from

Conversation

myuriy81
Copy link

@myuriy81 myuriy81 commented Jan 8, 2025

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code is well-structured and meets all the core requirements. The only minor suggestion is to optimize the getPreparedTodos function by directly returning the result of the map method, as it is already non-mutating. Keep up the excellent work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +13 to +18
return todosFromServer.map(todo => {
return {
...todo,
user: findUserById(todo.userId) || null,
};
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getPreparedTodos function uses map to transform todosFromServer. Since map is a non-mutating method, there is no need to create a copy of the array. You can directly return the result of map without wrapping it in another array. This aligns with the checklist item: "If you are using a non-mutating array method, you don't need to create a copy of the array."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants