-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO IT'S ALIVE!!!
#749
Open
mpohorenyi
wants to merge
1
commit into
mate-academy:master
Choose a base branch
from
mpohorenyi:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TODO IT'S ALIVE!!!
#749
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,93 +1,10 @@ | ||
/* eslint-disable jsx-a11y/control-has-associated-label */ | ||
import React from 'react'; | ||
|
||
export const App: React.FC = () => { | ||
return ( | ||
<div className="todoapp"> | ||
<header className="header"> | ||
<h1>todos</h1> | ||
|
||
<form> | ||
<input | ||
type="text" | ||
data-cy="createTodo" | ||
className="new-todo" | ||
placeholder="What needs to be done?" | ||
/> | ||
</form> | ||
</header> | ||
|
||
<section className="main"> | ||
<input | ||
type="checkbox" | ||
id="toggle-all" | ||
className="toggle-all" | ||
data-cy="toggleAll" | ||
/> | ||
<label htmlFor="toggle-all">Mark all as complete</label> | ||
|
||
<ul className="todo-list" data-cy="todoList"> | ||
<li> | ||
<div className="view"> | ||
<input type="checkbox" className="toggle" id="toggle-view" /> | ||
<label htmlFor="toggle-view">asdfghj</label> | ||
<button type="button" className="destroy" data-cy="deleteTodo" /> | ||
</div> | ||
<input type="text" className="edit" /> | ||
</li> | ||
|
||
<li className="completed"> | ||
<div className="view"> | ||
<input type="checkbox" className="toggle" id="toggle-completed" /> | ||
<label htmlFor="toggle-completed">qwertyuio</label> | ||
<button type="button" className="destroy" data-cy="deleteTodo" /> | ||
</div> | ||
<input type="text" className="edit" /> | ||
</li> | ||
|
||
<li className="editing"> | ||
<div className="view"> | ||
<input type="checkbox" className="toggle" id="toggle-editing" /> | ||
<label htmlFor="toggle-editing">zxcvbnm</label> | ||
<button type="button" className="destroy" data-cy="deleteTodo" /> | ||
</div> | ||
<input type="text" className="edit" /> | ||
</li> | ||
|
||
<li> | ||
<div className="view"> | ||
<input type="checkbox" className="toggle" id="toggle-view2" /> | ||
<label htmlFor="toggle-view2">1234567890</label> | ||
<button type="button" className="destroy" data-cy="deleteTodo" /> | ||
</div> | ||
<input type="text" className="edit" /> | ||
</li> | ||
</ul> | ||
</section> | ||
|
||
<footer className="footer"> | ||
<span className="todo-count" data-cy="todosCounter"> | ||
3 items left | ||
</span> | ||
|
||
<ul className="filters"> | ||
<li> | ||
<a href="#/" className="selected">All</a> | ||
</li> | ||
|
||
<li> | ||
<a href="#/active">Active</a> | ||
</li> | ||
|
||
<li> | ||
<a href="#/completed">Completed</a> | ||
</li> | ||
</ul> | ||
|
||
<button type="button" className="clear-completed"> | ||
Clear completed | ||
</button> | ||
</footer> | ||
</div> | ||
); | ||
}; | ||
import { TodosProvider } from './TodosContext'; | ||
import { TodoApp } from './components/TodoApp'; | ||
|
||
export const App: React.FC = () => ( | ||
<TodosProvider> | ||
<TodoApp /> | ||
</TodosProvider> | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
import React, { useState } from 'react'; | ||
import { Option } from './types/Option'; | ||
import { useLocalStorage } from './hooks/useLocalStorage'; | ||
import { Todo } from './types/Todo'; | ||
import { Context } from './types/Context'; | ||
|
||
const initialValue: Context = { | ||
todos: [], | ||
setTodos: () => { }, | ||
filter: Option.All, | ||
setFilter: () => { }, | ||
visibleTodos: [], | ||
isToggleCheckedAll: false, | ||
setIsToggleCheckedAll: () => {}, | ||
}; | ||
|
||
export const TodosContext = React.createContext(initialValue); | ||
|
||
type Props = { | ||
children: React.ReactNode; | ||
}; | ||
|
||
export const TodosProvider: React.FC<Props> = ({ children }) => { | ||
const [todos, setTodos] = useLocalStorage<Todo[]>('todos', []); | ||
const [filter, setFilter] = useState(Option.All); | ||
const [isToggleCheckedAll, setIsToggleCheckedAll] | ||
= useState(todos.every(todo => todo.completed)); | ||
|
||
const visibleTodos = todos.filter(todo => { | ||
switch (filter) { | ||
case Option.Active: | ||
return !todo.completed; | ||
|
||
case Option.Completed: | ||
return todo.completed; | ||
|
||
case Option.All: | ||
default: | ||
return true; | ||
} | ||
}); | ||
|
||
const context: Context = { | ||
todos, | ||
setTodos, | ||
filter, | ||
setFilter, | ||
visibleTodos, | ||
isToggleCheckedAll, | ||
setIsToggleCheckedAll, | ||
}; | ||
|
||
return ( | ||
<TodosContext.Provider value={context}> | ||
{children} | ||
</TodosContext.Provider> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
import React, { useContext } from 'react'; | ||
import cn from 'classnames'; | ||
import { TodosContext } from '../TodosContext'; | ||
import { Option } from '../types/Option'; | ||
|
||
export const Footer: React.FC = () => { | ||
const { | ||
todos, | ||
setTodos, | ||
filter, | ||
setFilter, | ||
} = useContext(TodosContext); | ||
|
||
const TotalUncompletedTodos = todos.filter(todo => !todo.completed); | ||
|
||
const isCompletedTodos = todos.some(todo => todo.completed); | ||
|
||
const cleanCompletedTodos = () => { | ||
setTodos(todos.filter(todo => !todo.completed)); | ||
}; | ||
|
||
return ( | ||
<footer className="footer" data-cy="todosFilter"> | ||
<span className="todo-count" data-cy="todosCounter"> | ||
{`${TotalUncompletedTodos.length} ${TotalUncompletedTodos.length === 1 ? 'item' : 'items'} left`} | ||
</span> | ||
|
||
<ul className="filters"> | ||
<li> | ||
<a | ||
href="#/" | ||
className={cn({ | ||
selected: filter === Option.All, | ||
})} | ||
onClick={() => setFilter(Option.All)} | ||
> | ||
All | ||
</a> | ||
</li> | ||
|
||
<li> | ||
<a | ||
href="#/active" | ||
className={cn({ | ||
selected: filter === Option.Active, | ||
})} | ||
onClick={() => setFilter(Option.Active)} | ||
> | ||
Active | ||
</a> | ||
</li> | ||
|
||
<li> | ||
<a | ||
href="#/completed" | ||
className={cn({ | ||
selected: filter === Option.Completed, | ||
})} | ||
onClick={() => setFilter(Option.Completed)} | ||
> | ||
Completed | ||
</a> | ||
</li> | ||
</ul> | ||
{isCompletedTodos && ( | ||
<button | ||
type="button" | ||
className="clear-completed" | ||
onClick={cleanCompletedTodos} | ||
> | ||
Clear completed | ||
</button> | ||
)} | ||
</footer> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import React, { useCallback, useContext, useState } from 'react'; | ||
import { TodosContext } from '../TodosContext'; | ||
import { Todo } from '../types/Todo'; | ||
|
||
export const Header: React.FC = () => { | ||
const { todos, setTodos, setIsToggleCheckedAll } = useContext(TodosContext); | ||
const [title, setTitle] = useState(''); | ||
|
||
const handleSubmit = useCallback(( | ||
event: React.FormEvent<HTMLFormElement>, | ||
) => { | ||
event.preventDefault(); | ||
|
||
if (!title.trim()) { | ||
return; | ||
} | ||
|
||
const newTodo: Todo = { | ||
id: +new Date(), | ||
title: title.trim(), | ||
completed: false, | ||
}; | ||
|
||
setTodos([...todos, newTodo]); | ||
setTitle(''); | ||
setIsToggleCheckedAll(false); | ||
}, [setIsToggleCheckedAll, setTodos, title, todos]); | ||
|
||
return ( | ||
<header className="header"> | ||
<h1>todos</h1> | ||
|
||
<form onSubmit={handleSubmit}> | ||
<input | ||
type="text" | ||
data-cy="createTodo" | ||
className="new-todo" | ||
placeholder="What needs to be done?" | ||
value={title} | ||
onChange={event => setTitle(event.target.value)} | ||
/> | ||
</form> | ||
</header> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,41 @@ | ||||||||||
/* eslint-disable jsx-a11y/control-has-associated-label */ | ||||||||||
import React, { useContext } from 'react'; | ||||||||||
import { TodosContext } from '../TodosContext'; | ||||||||||
import { TodoList } from './TodoList'; | ||||||||||
|
||||||||||
export const Main: React.FC = () => { | ||||||||||
const { | ||||||||||
todos, | ||||||||||
setTodos, | ||||||||||
visibleTodos, | ||||||||||
isToggleCheckedAll, | ||||||||||
setIsToggleCheckedAll, | ||||||||||
} = useContext(TodosContext); | ||||||||||
|
||||||||||
const checkAllTodos = () => { | ||||||||||
const newTodos = todos.map(todo => ( | ||||||||||
isToggleCheckedAll | ||||||||||
? { ...todo, completed: false } | ||||||||||
: { ...todo, completed: true } | ||||||||||
Comment on lines
+17
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
can be more simplify |
||||||||||
)); | ||||||||||
|
||||||||||
setTodos(newTodos); | ||||||||||
setIsToggleCheckedAll(!isToggleCheckedAll); | ||||||||||
}; | ||||||||||
|
||||||||||
return ( | ||||||||||
<section className="main"> | ||||||||||
<input | ||||||||||
type="checkbox" | ||||||||||
id="toggle-all" | ||||||||||
className="toggle-all" | ||||||||||
data-cy="toggleAll" | ||||||||||
checked={isToggleCheckedAll} | ||||||||||
onChange={checkAllTodos} | ||||||||||
/> | ||||||||||
<label htmlFor="toggle-all">Mark all as complete</label> | ||||||||||
|
||||||||||
<TodoList items={visibleTodos} /> | ||||||||||
</section> | ||||||||||
); | ||||||||||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import React, { useContext } from 'react'; | ||
import { Header } from './Header'; | ||
import { Main } from './Main'; | ||
import { Footer } from './Footer'; | ||
import { TodosContext } from '../TodosContext'; | ||
|
||
export const TodoApp: React.FC = () => { | ||
const { todos } = useContext(TodosContext); | ||
|
||
return ( | ||
<div className="todoapp"> | ||
<Header /> | ||
|
||
{!!todos.length && ( | ||
<> | ||
<Main /> | ||
|
||
<Footer /> | ||
</> | ||
)} | ||
</div> | ||
); | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍