Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToDo App #750

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

ToDo App #750

wants to merge 21 commits into from

Conversation

sviatikkondur
Copy link

StasSokolov1
StasSokolov1 approved these changes Oct 30, 2023
View reviewed changes
Copy link

@StasSokolov1 StasSokolov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, i'm approving it🔥

StasSokolov1
StasSokolov1 suggested changes Oct 30, 2023
View reviewed changes
Copy link

@StasSokolov1 StasSokolov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, let's improve your code a bit more!

  1. will be better prevent case when user input space
Снимок экрана 2023-10-30 в 13 11 51

src/hooks/useLocalStorage.tsx Outdated Show resolved Hide resolved
src/components/TodoList.tsx Outdated Show resolved Hide resolved
src/components/TodoItem.tsx Outdated Show resolved Hide resolved
src/components/TodoItem.tsx Outdated Show resolved Hide resolved
src/components/TodoItem.tsx Outdated Show resolved Hide resolved
src/components/TodoCount.tsx Outdated Show resolved Hide resolved
src/components/Main.tsx Outdated Show resolved Hide resolved
src/components/TodoItem.tsx Outdated Show resolved Hide resolved
src/components/TodoItem.tsx Outdated Show resolved Hide resolved
src/components/TodoItem.tsx Outdated Show resolved Hide resolved
yuliabakun
yuliabakun approved these changes Oct 30, 2023
View reviewed changes
Copy link

@yuliabakun yuliabakun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

src/components/Header.tsx Show resolved Hide resolved
polosanya
polosanya approved these changes Oct 31, 2023
View reviewed changes
Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I'm approving it, but please pay attention to the comments)

src/components/TodoCount.tsx Outdated Show resolved Hide resolved
src/components/TodoItem.tsx Outdated Show resolved Hide resolved
src/components/TodoItem.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliabakun yuliabakun yuliabakun approved these changes

@polosanya polosanya polosanya approved these changes

@StasSokolov1 StasSokolov1 Awaiting requested review from StasSokolov1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sviatikkondur @StasSokolov1 @yuliabakun @polosanya