👉🏻Develop👌🏻 #752
Open
👉🏻Develop👌🏻 #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Oct 29, 2023
Comment on lines
+11
to
+21
| const todosContext = useContext(TodosContext); | ||
|
|
||
| const { | ||
| todos, | ||
| addTodo, | ||
| deleteCompletedTodos, | ||
| handleToggleAll, | ||
| todoCount, | ||
| completedTodos, | ||
| filterTodos, | ||
| } = todosContext; |
There was a problem hiding this comment.
you can do it directly
Suggested change
| const todosContext = useContext(TodosContext); | |
| const { | |
| todos, | |
| addTodo, | |
| deleteCompletedTodos, | |
| handleToggleAll, | |
| todoCount, | |
| completedTodos, | |
| filterTodos, | |
| } = todosContext; | |
| const { | |
| todos, | |
| addTodo, | |
| deleteCompletedTodos, | |
| handleToggleAll, | |
| todoCount, | |
| completedTodos, | |
| filterTodos, | |
| } = useContext(TodosContext); |
src/components/TodosContext.tsx
Outdated
Comment on lines
89
to
100
| useEffect(() => { | ||
| const storedTodos = localStorage.getItem('todos'); | ||
|
|
||
| if (storedTodos) { | ||
| setTodos(JSON.parse(storedTodos)); | ||
| } | ||
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| localStorage.setItem('todos', JSON.stringify(todos)); | ||
| }, [todos]); | ||
|
|
There was a problem hiding this comment.
actually, you can move this logic to useLocaleStrorage hook, it will simplify the logic
| <li> | ||
| <a | ||
| href="#/active" | ||
| className={filter === 'active' ? 'selected' : ''} |
There was a problem hiding this comment.
we usually use classnames for such cases
src/components/TodoFilter.tsx
Outdated
| <li> | ||
| <a | ||
| href="#/" | ||
| className={filter === 'all' ? 'selected' : ''} |
There was a problem hiding this comment.
Suggested change
| className={filter === 'all' ? 'selected' : ''} | |
| className={filter === Filter.All ? 'selected' : ''} |
src/components/TodoFilter.tsx
Outdated
Comment on lines
17
to
19
| <a | ||
| href="#/" | ||
| className={filter === 'all' ? 'selected' : ''} |
There was a problem hiding this comment.
also, I suggest you can create some links array and render them in the loop(using the .map)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://denys2.github.io/react_todo-app/