Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the preference for the minimum size of faces but it remains as… #310

Merged
merged 3 commits into from
Aug 2, 2020

Conversation

matiasdelellis
Copy link
Owner

Remove the preference for the minimum size of faces but it remains as an advanced option.
The minimum face size to cluster is 60.

The extreme case is the nextcloud community photo.

Nextcloud community

This is a picture of 3000 × 2000 píxeles and without any resizing the faces that I find are these ..

[matias@ideapad test]$ php test.php 
Found 60 faces.
1: 40x39px
2: 47x47px
3: 47x47px
4: 47x47px
5: 48x47px
6: 57x57px
7: 40x39px
8: 47x47px
9: 40x39px
10: 47x47px
11: 40x39px
12: 40x39px
13: 48x47px
14: 48x47px
15: 40x39px
16: 57x57px
17: 47x47px
18: 40x39px
19: 47x48px
20: 47x47px
21: 47x48px
22: 40x39px
23: 40x39px
24: 40x39px
25: 57x57px
26: 40x39px
27: 40x39px
28: 40x39px
29: 48x48px
30: 48x47px
31: 40x39px
32: 40x39px
33: 40x39px
34: 47x47px
35: 57x57px
36: 40x39px
37: 40x39px
38: 40x39px
39: 40x39px
40: 40x39px
41: 40x39px
42: 40x39px
43: 40x39px
44: 40x39px
45: 40x39px
46: 40x39px
47: 47x47px
48: 47x48px
49: 48x47px
50: 47x47px
51: 40x39px
52: 40x39px
53: 40x39px
54: 40x39px
55: 40x39px
56: 40x39px
57: 40x39px
58: 40x39px
59: 57x57px
60: 40x39px

Great except I need 18 Gb of ram to read it. 😅

If I resize the image 66%, use 8Gb of ram ,I get 25 percent faces, but still similar sizes

[matias@ideapad test]$ php test.php 
Found 18 faces.
1: 40x39px
2: 40x39px
3: 40x39px
4: 40x39px
5: 40x39px
6: 40x39px
7: 40x39px
8: 40x39px
9: 40x39px
10: 40x39px
11: 40x39px
12: 40x39px
13: 40x39px
14: 40x39px
15: 40x39px
16: 40x39px
17: 40x39px
18: 40x39px

...and it certainly looks good, but you can already see it pixelated ..

Well .. Basically I avoid clusterinf these faces.. 99% of the photos don't have so many faces.. and therefore it won't be a problem...

In any case, they will be suggested when implement #262

@matiasdelellis matiasdelellis merged commit 84d6539 into master Aug 2, 2020
@matiasdelellis matiasdelellis deleted the hide-min-face branch August 2, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant