check if value exists befor using it

[mikkeschiren]

Description:

If no URLs are added to the URL field when creating a new website, you get a warning in the log of missing value for the array $settings['value'].
This suggested patch checks if $settings['value'] exists.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[michalkleiner]

Hi @mikkeschiren, thanks for the PR, however after looking at the code in a bit more detail, I think we can't just simply "not use the value when it's not provided" as the mechanism is setting different types of measurable configurations and each may require different treatment of the empty value, some might be arrays, some might be false, so just omitting is probably not the correct solution.

[mikkeschiren]

How should we change the check so we do not get the warnings? Should I change it to just look for the url field?