review (implement interface, make interface internal, dont change pub…

…lic api.)

src/matrixrtc/MatrixRTCSession.ts

@@ -754,6 +754,14 @@ export class MatrixRTCSession extends TypedEventEmitter<MatrixRTCSessionEvent, M
     private isMyMembership = (m: CallMembership): boolean =>
         m.sender === this.client.getUserId() && m.deviceId === this.client.getDeviceId();
 
+    /**
+     * @deprecated use onMembershipsUpdate instead. this should be called when any membership in the call is updated
+     * the old name might have implied to only need to call this when your own membership changes.
+     */
+    public onMembershipUpdate = (): void => {
+        this.onMembershipsUpdate();
+    };
+
     /**
      * Examines the latest call memberships and handles any encryption key sending or rotation that is needed.
      *

src/matrixrtc/MembershipManager.ts

@@ -10,7 +10,13 @@ import { CallMembership, DEFAULT_EXPIRE_DURATION, SessionMembershipData } from "
 import { Focus } from "./focus.ts";
 import { isLivekitFocusActive } from "./LivekitFocus.ts";
 import { MembershipConfig } from "./MatrixRTCSession.ts";
-
+/**
+ * This interface defines what a MembershipManager uses and exposes.
+ * This interface is what we use to write tests and allows to change the actual implementation
+ * Without breaking tests because of some internal method renaming.
+ *
+ * @internal
+ */
 export abstract class MembershipManagerInterface {
     public constructor(
         joinConfig: MembershipConfig | undefined,
@@ -48,7 +54,7 @@ export abstract class MembershipManagerInterface {
  *
  *  @internal
  */
-export class MembershipManager {
+export class MembershipManager implements MembershipManagerInterface {
     private relativeExpiry: number | undefined;
 
     private memberEventTimeout?: ReturnType<typeof setTimeout>;