Upload device keys during initCrypto #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't really needed, and its semantics are poorly defined. (Contrary to the comment, it dos *not* set background processes running).
Rather than waiting for the application to call `.startClient`, upload the device keys during `initCrypto()`. Element-R is going to approach this slightly differently (it wants to manage the decision on key uploads itself), so this lays some groundwork by collecting the libolm-specific bits together.
SimonBrandner
approved these changes
Nov 11, 2022
richvdh
force-pushed
the
rav/remove_upload_keys
branch
from
6428643 to
1ec2e3b
Compare
|
Very little has actually changed since Simon's review (https://github.com/matrix-org/matrix-js-sdk/pull/2872/files/ed1a63726a2d47ae57d0339f8c3d4c7acf787bcf..1ec2e3b399806fa007f72886337ffe9544a55588) so I'm going to consider his review as still good, and merge this. |
|
(or I will, if I can ever get the typescript checks to pass. Looks like we need to wait for #2895) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than waiting for the application to call
.startClient, upload the device keys duringinitCrypto(). Element-R is going to approach this slightly differently (it wants to manage the decision on key uploads itself), so this lays some groundwork by collecting the libolm-specific bits together.Based on #2871
Part of element-hq/element-web#21972
This change is marked as an internal change (Task), so will not be included in the changelog.