Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send MSC3981 'recurse' param on /relations endpoint on Matrix 1.10 servers #4023

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 22, 2024

So we will send the 'recurse' parameter unprefixed for servers that support 1.10 (which most should now do, since it's released).

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

So we will send the 'recurse' parameter unprefixed for servers that
support 1.10 (when it's released).
@dbkr dbkr added the T-Task Tasks for the team like planning label Jan 22, 2024
@dbkr dbkr marked this pull request as ready for review January 22, 2024 18:09
@dbkr dbkr requested a review from a team as a code owner January 22, 2024 18:09
@dbkr dbkr requested review from richvdh and MidhunSureshR January 22, 2024 18:09
@richvdh
Copy link
Member

richvdh commented Jan 23, 2024

For links: this is about matrix-org/matrix-spec-proposals#3981.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you're not allowed to do this yet, because it will create problems if the MSC doesn't get written up by the time spec v1.10 is released.

@dbkr
Copy link
Member Author

dbkr commented Jan 24, 2024

Fair enough, I'll leave it as a draft until then.

@dbkr dbkr marked this pull request as draft January 24, 2024 10:00
@MidhunSureshR MidhunSureshR removed their request for review November 21, 2024 06:42
@dbkr dbkr marked this pull request as ready for review January 2, 2025 12:38
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Could do with a changelog entry though.

@dbkr
Copy link
Member Author

dbkr commented Jan 10, 2025

Changelog entry will be done by the release process from the PR title.

@richvdh
Copy link
Member

richvdh commented Jan 10, 2025

Changelog entry will be done by the release process from the PR title.

Not if it's T-Task, I think?

Also, "Mark MSC3981 as stable in Matrix 1.10" is a crap changelog entry. What does it actually mean, for a user of matrix-js-sdk?

@dbkr dbkr added T-Enhancement and removed T-Task Tasks for the team like planning labels Jan 10, 2025
@dbkr dbkr changed the title Mark MSC3981 as stable in Matrix 1.10 Send MSC3981 'recurse' param on /relations endpoint on Matrix 1.10 servers Jan 10, 2025
@dbkr
Copy link
Member Author

dbkr commented Jan 10, 2025

Done, hopefully this is okay information-density wise.

@dbkr dbkr requested a review from richvdh January 10, 2025 14:48
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants