Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authenticated media to getAvatarUrl in room and room-member models #4616

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add authenticated media to getAvatarUrl in room and room-member models #4616

wants to merge 1 commit into from
+108 −2

Conversation

m004
Copy link

@m004 m004 commented Jan 14, 2025

Fixes getAvatarUrl in src/models/room.ts and src/models/room-member.ts not working on homeservers that enforce authenticated media

Signed-off-by: Maurizio Abbruzzo maurizio@abbruzzosantiago.de

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@m004 m004 requested a review from a team as a code owner January 14, 2025 18:17
@m004 m004 requested review from dbkr and florianduros January 14, 2025 18:17
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m004 @t3chguy