Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Enable tests fixed by matrix-org/matrix-js-sdk#3800 (#11764)
Browse files Browse the repository at this point in the history
* Update comments on flaky tests

* Enable a test that is fixed by matrix-js-sdk#3800
  • Loading branch information
andybalaam authored Nov 15, 2023
1 parent f6ef476 commit 9564009
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions cypress/e2e/read-receipts/redactions.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ describe("Read receipts", () => {
goTo(room2);
assertReadThread("Root");
});
// XXX: fails because sometimes the room is still unread after opening the thread (initially)
// XXX: fails because it flakes - sometimes the room is still unread after opening the thread (initially)
it.skip("Reacting to a redacted message leaves the thread read", () => {
// Given a message in a thread was redacted and everything is read
goTo(room1);
Expand Down Expand Up @@ -541,8 +541,7 @@ describe("Read receipts", () => {
// Then the room is unread
assertStillRead(room2);
});
// XXX: fails because the room still shows "1" even though we have read the thread (stuck unread)
it.skip("Reading a reaction to a redacted message marks the thread as read", () => {
it("Reading a thread after a reaction to a redacted message marks the thread as read", () => {
// Given a redacted message in a thread exists, but someone reacted to it before it was redacted
goTo(room1);
receiveMessages(room2, [
Expand All @@ -555,7 +554,7 @@ describe("Read receipts", () => {
receiveMessages(room2, [redactionOf("Msg3")]);
assertUnread(room2, 2);

// When we read the thread, creating a receipt that points at the reaction
// When we read the thread
goTo(room2);
openThread("Root");

Expand Down

0 comments on commit 9564009

Please sign in to comment.