Rename Sessions to Devices throughout the app

[dbkr]

I've left the keys as-is so this will also need doing in each language, but will continue to say whatever it says currently until then, rather than suddenly needing all new translations.

Checklist

• Tests written for new code (and old code if feasible).
• New or updated public/exported symbols have accurate TSDoc documentation.
• Linter and other CI checks pass.
• Sign-off given on the changes (see CONTRIBUTING.md).

[t3chguy]

I think it ought to be consistent with all other places we chose Sessions over Device previously, these are just a sampling:

[t3chguy]

Asking for product input regarding this change landing due to how it misaligns with current stable Element mobile apps which use sessions. This likely breaks the Legacy login QR instructions on the Element mobile apps which a customer is depending on as they guide to the Devices tab AIUI.

@dbkr can you update the PR title to reflect reality better for the changelog

[americanrefugee]

@t3chguy I'll pitch in with some product perspective...

When developing the new flows for the first time user experience (FTUE), the new MAS OIDC experience, and QR code sign in, @pmaier1 and I have been advocating for this change.

Although "sessions" has been the historical term we've used, and is the most accurate technically, it's not a word most users encounter in other apps. For example, both WhatsApp and Telegram use the term "Devices". Furthermore, the only time when a "session" becomes a technical distinction is if a user is signed into both Element Web and Element Desktop, which should be rare. In the vast majority of cases for normal users, they will be signed into Element only in one app per device.

In order to avoid confusion and to avoid having to explain what a "session" is, we therefore strongly suggest changing it to "devices".

Not sure how we handle the breaking changes this would create. Maybe @pmaier1 has some insight?

[t3chguy]

if a user is signed into both Element Web and Element Desktop

Or multiple Element Webs, or multiple Element Desktops, or either of the aforementioned + Element X on macOS (Apple Silicon), or a mix of any of those. Or more concretely, they log out and back in, often users expect that to be the same device.

[americanrefugee]

if a user is signed into both Element Web and Element Desktop

Or multiple Element Webs, or multiple Element Desktops, or either of the aforementioned + Element X on macOS (Apple Silicon), or a mix of any of those. Or more concretely, they log out and back in, often users expect that to be the same device.

Ok, so there are more scenarios possible... but how common are those for our clients?

More importantly, I'm not convinced that users will get confused when signing in. With QR code sign in, for example, they need to use another device, not just another "session". And it's much clearer to say "Open Element on your mobile device/a desktop device" rather than "Open a session of Element of your mobile/desktop device". Also, if not authenticating with another device then they use a recovery code which has nothing to do with devices.

WDYT @pmaier1 ?

[t3chguy]

With QR code sign in, for example, they need to use another device, not just another "session"

Not necessarily true. Element X on macOS could be used to scan a QR code from Element Web/Desktop on the same device.

[americanrefugee]

With QR code sign in, for example, they need to use another device, not just another "session"

Not necessarily true. Element X on macOS could be used to scan a QR code from Element Web/Desktop on the same device.

...how? Even if the desktop camera could detect the code, there's no way to actually point it at the screen it's connected to. Right? Unless the use has an external camera... but then that's WAY deep in the weeds of edge cases.

[t3chguy]

...how? Even if the desktop camera could detect the code, there's no way to actually point it at the screen it's connected to. Right? Unless the use has an external camera... but then that's WAY deep in the weeds of edge cases.

One can have multiple monitors, Apple devices also allow you to use your iPhone as a webcam.

[pmaier1]

This is a matter of old world vs. new world (EX). We take the opportunity with Element X to improve usability. That includes wordings (e.g., recovery key, chat backup, devices). "Devices" is the new terminology in MAS. We decided for it going forward as we are convinced it's less technical than sessions and will (for most ordinary users) be equal to it. Also "devices" is a more well-known pattern than "sessions" if you look at competition.

But, as @t3chguy rightfully points out in #12500 (comment) we need to maintain consistency with what's the currently stable set of products. Today this isn't yet EX which makes this a matter of timing. We should only switch all the wordings and align behavior with EX once it supersedes the existing mobile apps.

[richvdh]

We should only switch all the wordings and align behavior with EX once it supersedes the existing mobile apps.

Sounds like we're not ready for this yet, then. @dbkr: shall we close it for now, to avoid cluttering the pull-request list?

(We should probably have an issue for this, which can be tracked by element-hq/element-meta#2487)

[dbkr]

Oh, yes - this has lots of conflicts so may as well be closed.