This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Convert sticker end-to-end tests to Cypress #8807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference materials: * https://www.cypress.io/blog/2020/02/12/working-with-iframes-in-cypress/ * cypress-io/cypress#136 * https://docs.cypress.io/api/commands/origin#Other-limitations Ideally we'd be able to use `cy.origin()` to jump into the iframe, but it's explicitly not supported. Instead we disable web security as instructed by cypress because it's our only reasonable option here. Thankfully, disabling web security doesn't appear to remove the crypto libraries from the browser so we can still function in that respect. Rationale for why we can't just serve the sticker picker off the app domain is included in the code.
turt2live
added
the
T-Task
weeman1337
approved these changes
Jun 10, 2022
t3chguy
reviewed
Jun 10, 2022
| @@ -7,5 +7,6 @@ | |||
| "retries": { | |||
| "runMode": 2, | |||
| "openMode": 0 | |||
| } | |||
| }, | |||
| "chromeWebSecurity": false | |||
There was a problem hiding this comment.
The tests should also be runnable in firefox, do they work there?
There was a problem hiding this comment.
How does one run them in Firefox? (Should we be enabling that in CI?)
There was a problem hiding this comment.
test:cypress:open then pick your favourite installed Firefox version in the dropdown in the top right
Yeah ideally we'd run CI on Firefox & Chrome & Electron, but Electron doesn't work properly in CI for some reason
There was a problem hiding this comment.
it even says it won't :D
FF is the only one with the warning though:
the tests also just don't run at all in FF:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference materials:
Ideally we'd be able to use
cy.origin()to jump into the iframe, but it's explicitly not supported. Instead we disable web security as instructed by cypress because it's our only reasonable option here. Thankfully, disabling web security doesn't appear to remove the crypto libraries from the browser so we can still function in that respect.Rationale for why we can't just serve the sticker picker off the app domain is included in the code.
Please thumbs-up cypress-io/cypress#136 if you don't mind 😇
element-web notes: None
Fixes element-hq/element-web#22450
This change is marked as an internal change (Task), so will not be included in the changelog.