Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish a dual CJS/ESM package with platform-specific loaders #167
Publish a dual CJS/ESM package with platform-specific loaders #167
Changes from all commits
eeb5a8d
87daf68
0db7123
246c0e3
4be81bf
0d699f6
accdcf7
b89ec58
87eb739
f8c2b56
71dc1f8
b408e3e
57b5da0
148e642
10c2119
0a596f8
5fe0909
7202b78
7e7c15c
d7d3424
9c4cb0a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually throws if you call
initAsync
, it loads in the background, and then init it synchronously before it finishes; but I think it is fine to throw because the consumer shouldn't do thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it? In that case, wouldn't
modPromise
be set, so that the synchronous init will fail early with an exception?