Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop deleting build results during rebuilds #175

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Dec 4, 2024

This solves a problem, introduced in #167, with the webpack-dev-server, which would see the half-built javascript output and explode with a big error about Can't resolve './pkg/matrix_sdk_crypto_wasm_bg.js'

(See also #109, where a similar problem was fixed before.)

This solves a problem with the webpack-dev-server, which would see the
half-built javascript output and explode with a big error about `Can't resolve
'./pkg/matrix_sdk_crypto_wasm_bg.js'`
@richvdh richvdh mentioned this pull request Dec 4, 2024
@richvdh richvdh marked this pull request as ready for review December 5, 2024 10:46
@richvdh richvdh requested a review from a team as a code owner December 5, 2024 10:46
@richvdh richvdh requested a review from BillCarsonFr December 5, 2024 10:46
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks feasible

@andybalaam andybalaam removed the request for review from BillCarsonFr December 5, 2024 14:50
@richvdh richvdh merged commit 2313de1 into main Dec 5, 2024
6 checks passed
@richvdh richvdh deleted the rav/fix_temp_build_failure_again branch December 5, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants