Remove the origin field in PUT /send_join responses
#2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a spec bug as it has actually never been sent by Synapse, going back to 2014. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although other removals of
originin the spec might require a MSC, this case is a spec bug as it has actually never been sent by Synapse, going back to 2014:auth_chainwas added: element-hq/synapse@3b4dec4The current state is that it is not sent and ignored when received by Synapse, Conduit, Conduwuit, and it is sent by Dendrite but ignored when received.
Part of #374.
Pull Request Checklist
Preview: https://pr2050--matrix-spec-previews.netlify.app