Skip to content
This repository has been archived by the owner on Oct 6, 2024. It is now read-only.

Add locale of korean #16

Closed
wants to merge 5 commits into from
Closed

Add locale of korean #16

wants to merge 5 commits into from

Conversation

HotoRas
Copy link

@HotoRas HotoRas commented Jul 20, 2024

  • add korean (ko) as display language

HotoRas added 3 commits June 23, 2024 09:29
@HotoRas
feat(l10n): Korean localization step 1
31a71bd 
The content is not tested right now.
@HotoRas
Allow korean be selectable
cacf17c 
by editing locales_config
@HotoRas
locale(ko): korean localization plase 2
87e29e3 
Up to developer mode title
@HotoRas
Copy link
Author

HotoRas commented Jul 20, 2024

I'll have to notify this is still draft rn- I want to translate all strings into korean and fix some typo in english (\' displays directly, $,d renders as $d etc).

HotoRas added 2 commits July 21, 2024 09:00
@HotoRas
locale(ko): korean localization phase 3 (final)
1d6f1c8 
Done for all strings
@HotoRas
chore(locale): Fix typos on locales
ae2fcf5 
- \' will render as \'
- %,d will render as %d
@HotoRas HotoRas marked this pull request as ready for review July 21, 2024 00:03
@HotoRas HotoRas requested a review from matsumo0922 as a code owner July 21, 2024 00:03
@github-actions GitHub Actions
Copy link

✨ ✨ That's perfect, passed the PR lint check perfectly! ✨ ✨

@matsumo0922
Copy link
Owner

Nice translate! 👍
CI seems to be failing, which I'll fix and merge in.

@HotoRas
Copy link
Author

HotoRas commented Jul 29, 2024

The commit content is done and ready to be checked- but I don't know how it will be when compiled (I worked solely on vscode and had no chance of building and flighting) so please consider about this.

@matsumo0922 matsumo0922 mentioned this pull request Aug 10, 2024
Merged
@matsumo0922
Copy link
Owner

@HotoRas

We are creating a new repository, a KMP version of this application.
We plan to develop in that repository in the future and will archive this repository.

Therefore, we have ported your PR to the following PR.
Once again, thanks for your contribution!

@matsumo0922
Copy link
Owner

And I have submitted the app incorporating your changes to Google Play today :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matsumo0922 matsumo0922 Awaiting requested review from matsumo0922 matsumo0922 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HotoRas @matsumo0922