fix: anvil-zksync able to start even if the port is busy #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
approved these changes
Jan 16, 2025
itegulov
reviewed
Jan 17, 2025
| host, | ||
| config.port, | ||
| err | ||
| ); |
There was a problem hiding this comment.
Hmm, I don't think this is a good fallback. If I were running a tool in CI and saw this behaviour I would have been unpleasantly surprised.
There was a problem hiding this comment.
Hm, indeed. I though for a second that anvil does that -- but no:
anvil
Error: Address already in use (os error 98)
Location:
/home/runner/work/foundry/foundry/crates/anvil/src/lib.rs:229:28
I guess we have to replace the fallback with just error propagation.
mm-zk
added a commit
that referenced
this pull request
Jan 17, 2025
* refactor: reduce usage of `ForkStorage` outside `inner` module (#539) * reduce usage of `ForkStorage` outside `inner` module * adapt for zkos * fix destination path (#541) * fix: anvil-zksync able to start even if the port is busy (#542) * fix: closes #512 - start instance even if port is busy * chore: apply make lint:fix * chore: refactor test to make use of anvil-zksync instance * chore: remove no longer needed deps * chore: remove no longer needed deps * chore: bump actions/upload-artifact: v3 to v4 due to CI fail * chore: bump actions/upload-artifact / download: v3 to v4 due to CI fail * compilation fixes --------- Co-authored-by: Daniyar Itegulov <ditegulov@gmail.com> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Dustin Brickwood <dustinbrickwood204@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Why ✋
Evidence 📷