Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor slider #43

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

drmacm
Copy link

@drmacm drmacm commented Jan 7, 2021

This pull request replaces #42.

In addition to settings, this pull request includes refactoring of SleekCircularSlider and CurvePainter. The parameters for SleekCircularSlider are divided into:

  • CircularSliderSettings (more info in the previous pull requests)
  • CircularSliderValues (minimumValue, maximumValue, initialValue, angles and widths)
  • CircularSliderCallbacks (3 callback functions)
  • CircularSliderPainters (custom painters for background, shadow, progress bar and current value)

All the painters have uniform interface, accepting settings and values, so it's much easier to provide custom implementations for parts of the UI.

@matthewfx
Copy link
Owner

Hey,
I should have more time from the beginning of April. I left my day job and will fully focus on my ideas. I don't want your work to be in vain so could you please fix the animation for the programmatical value changes and the default properties when someone initializes the slider without any custom values (vide example no. 1). In addition to that, you would need to add the null safety now. Please let me know if could do it - otherwise, I might try to do it by myself. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants