Update cpl_rotations_db.csv #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOT-23 should be -90°, and I've added WSON-8-1EP_6x5mm_P1.27mm and set it to -90°. Values were verified by uploading a project to JLCPCB using these footprints and seeing that no further correction was needed.
rotation no longer needed for QFN
|
Unfortunately we have since learned that JLC's canonical orientations are based on component orientation on reels, so the way we are doing it based on footprint is fundamentally broken, and that's likely what caused the discrepancies. I'll merge this but do keep that in mind. I'm thinking about shutting this project down in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOT-23 should be -90°, and I've added WSON-8-1EP_6x5mm_P1.27mm and set it to -90°. QFN no longer needs to be rotated (at least not QFN-56-1EP_7x7mm_P0.4mm_EP3.2x3.2mm).
Values were verified by uploading a project to JLCPCB using these footprints and seeing that no further correction was needed.