Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #14

Open
evaenns opened this issue Dec 9, 2024 · 1 comment
Open

Documentation #14

evaenns opened this issue Dec 9, 2024 · 1 comment
Assignees

Comments

@evaenns
Copy link

evaenns commented Dec 9, 2024

Documentation of openmpp functions could be improved. Currently it is quite terse. Perhaps it is relying on an understand of OpenM++ nomenclature, but to function as a standalone R package, more plain text description of functions (including as they related to OpenM++ functionality is needed). Many documentation files also include a long list of usage examples, but do not describe what these different uses do. e.g.
https://github.com/mattwarkentin/openmpp/blob/1e62533966619e9641658096395bf607f2d2e050/man/get_workset.Rd#L25C1-L62C40

Part of: openjournals/joss-reviews#7435

@mattwarkentin mattwarkentin self-assigned this Jan 6, 2025
@mattwarkentin
Copy link
Owner

Documentation of openmpp functions could be improved. Currently it is quite terse.

Many/most of the functions exported by this package are very low-level API endpoints that the vast majority of users won't/shouldn't use directly. But we do export them for completeness. Those who seek to use these functions will likely be more expert.

The main classes (OpenMppModel, OpenMppWorkset, OpenMppModelRun, OpenMppModelRunSet) and commonly-used functions (e.g., load_model(), etc.) are documented fairly extensively.

Many documentation files also include a long list of usage examples, but do not describe what these different uses do. e.g.

These files which contain many usage examples are the low-level functions described above that we don't really expect most users will ever need to use directly. We believe that those users that seek to use these functions directly will have an expert understanding of when and how to use them.

However, to improve the ability for users to understand these low-level functions, we have updated all of our documentation to include links to the source documentation for these API endpoints. For example:

#' OpenM++ Administrative Tasks
#'
#' Functions for performing administrative tasks. More information about the
#' administrative API endpoints can be found at [here](https://github.com/openmpp/openmpp.github.io/wiki/Oms-web-service-API#administrative-manage-web-service-state).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants