Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating userList #161

Closed
wants to merge 23 commits into from
Closed

Deprecating userList #161

wants to merge 23 commits into from

Conversation

adRn-s
Copy link
Member

@adRn-s adRn-s commented Nov 2, 2023

This code needs to be tested (e.g. args.project[0].split("_")[1], passed to the new function that replaces fetchFirstNameAndEmail should be the 4-digit project ID).

The new API endpoint is yet to be deployed to production. I'm only opening the PR as a draft on the functionality that we'll be able to use soon.

@adRn-s
Copy link
Member Author

adRn-s commented Nov 28, 2023

Production deployment of Parkour2 is ready to use this implementation.

@adRn-s adRn-s requested a review from caballero November 28, 2023 09:23
Copy link
Contributor

@caballero caballero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are ok

@adRn-s
Copy link
Member Author

adRn-s commented Jan 15, 2024

I've already tried rebasing this 2 times, and I'm unable to merge due to conflicts... I will have to do a new PR since this was stale for too long...

@adRn-s adRn-s closed this Jan 15, 2024
@adRn-s
Copy link
Member Author

adRn-s commented Jan 15, 2024

Ah, the issue was that getProjectIDs is no longer responsible to fetching this data, the main loop does it now. Ok, new pull #175 will be open soon...

@adRn-s adRn-s deleted the get_contact_details branch January 15, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants