scalar id support

mbretter · May 7, 2021 · 44abf5d · 44abf5d
1 parent 8883fb5
commit 44abf5d
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/src/Stk/MongoDB/Connector.php b/src/Stk/MongoDB/Connector.php
@@ -176,7 +176,7 @@ public function update(
         }
 
         if ($criteria === null) {
-            $criteria = ['_id' => new ObjectId($row->get('_id'))];
+            $criteria = ['_id' => is_string($row->get('_id')) ? new ObjectId($row->get('_id')) : $row->get('_id')];
         }
 
         $this->debug(__METHOD__ . ':' . $this->_collection->getCollectionName() . ':' . print_r($criteria,

diff --git a/test/unit/Stk/MongoDB/ConntectorTest.php b/test/unit/Stk/MongoDB/ConntectorTest.php
@@ -360,6 +360,33 @@ public function testBuildValueSetWithPrefix(): void
         ], $set);
     }
 
+    public function testUpdateWithIntId(): void
+    {
+        $id  = 234;
+        $row = new Record([
+            '_id' => $id,
+            'foo' => 'bar'
+        ]);
+
+        $fields = [
+            '$set' => [
+                'alice' => 'bob'
+            ]
+        ];
+
+        $this->collection->expects($this->once())->method('updateOne')->with(
+            ['_id' => $id],
+            [
+                '$set' => [
+                    'foo'   => 'bar',
+                    'alice' => 'bob'
+                ]
+            ],
+            []
+        );
+        $this->connector->update($row, $fields);
+    }
+
     // insert
 
     public function testInsert(): void