Add tvOS support; Add trackSiteSearch
support; Make iOS/tvOS trackView implementation in sync with Android; Make Android trackEvent implementation in sync with iOS/tvOS
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
react-native-tvos
).trackSiteSearch
methodtrackView
method on iOS / tvOS to behave like on the Android. Maketitle
parameter optionalOn Android
trackView
looks like this:As you can see, it takes title if available or route. When we do deeper into SDK it looks like this:
It sets
route
aspath
parameter:and it sets
title
as aaction name
parameter:When we look into iOS implementation:
You can see that
view
is set asaction
param andurl
param is build based onaction
. With the changetrackView
will run the same way on both plaforms as expected.trackEvent
implementation in sync with iOS/tvOS. iOS allows to set url as optional param. The same should be possible with Android.