Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows/labeler): grant "issues: write" permission #25142

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Nov 20, 2024

Summary

The label-by-size job is failing silently, because it doesn't have the issues: write permission, which it needs, because pr-size-labeler currently uses the issues API (PATCH issues/{id}) rather than the issue label API (POST issues/{id}/labels).

Test results and supporting details

Related issues

Same PR in mdn/content:

Upstream PR removing the dependency on that permission:

@github-actions github-actions bot added the infra Infrastructure issues (npm, GitHub Actions, releases) of this project label Nov 20, 2024
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval, as mdn/content has the same permission granted.

@caugner caugner merged commit 8b4b2b7 into main Nov 20, 2024
8 checks passed
@caugner caugner deleted the let-labeler-write-issues branch November 20, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant