-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use lang: cmd on windows #1040
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wait i just noticed this is wrong it should show a tab or something for windows user to either use bash or powershell which are different the current command will not work in powershell, so users will try to run it and it will fail |
@louis030195 My change was wrong , I'm on linux for the moment. BTW , everytime I start development on linux , In screenpipe , it always generate these files. Can you explain why are they not present on repo itself most importantly , why is the linux-schema.json not on repo ? |
Signed-off-by: divanshu-go <divanshugrover2009@gmail.com>
66862cb
to
c5005ad
Compare
idk about linux-schema - probably because i dont use linux but u can commit it |
@louis030195 Do we need to support both Windows Powershell and Windows CMD My suggestion --> cmd is enough , its easier In the codebase you are also supporting windows cmd |
name: pull request
about: submit changes to the project
title: "[pr] "
labels: ''
assignees: ''
description
Earlier , we were showing the commands on windows as "bash". But know it shows cmd on windows which is the expected
related issue: #1039
how to test
add a few steps to test the pr in the most time efficient way.
if relevant add screenshots or screen captures to prove that this PR works to save us time.
if you think it can take more than 30 mins for us to review, we will pay between $20 and $200 for someone to review it for us, just ask in the pr.