Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use lang: cmd on windows #1040

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

divanshu-go
Copy link
Contributor

@divanshu-go divanshu-go commented Dec 23, 2024


name: pull request
about: submit changes to the project
title: "[pr] "
labels: ''
assignees: ''


description

Earlier , we were showing the commands on windows as "bash". But know it shows cmd on windows which is the expected
related issue: #1039

how to test

add a few steps to test the pr in the most time efficient way.

if relevant add screenshots or screen captures to prove that this PR works to save us time.

if you think it can take more than 30 mins for us to review, we will pay between $20 and $200 for someone to review it for us, just ask in the pr.

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2024 1:22pm

@louis030195
Copy link
Collaborator

wait i just noticed this is wrong

it should show a tab or something for windows user to either use bash or powershell which are different

the current command will not work in powershell, so users will try to run it and it will fail

@divanshu-go
Copy link
Contributor Author

@louis030195 My change was wrong ,
Instead of showing powershell , I suggest that we use cmd

I'm on linux for the moment.
It shows bash
for a user on windows it will say cmd
image

BTW , everytime I start development on linux , In screenpipe , it always generate these files. Can you explain why are they not present on repo itself
image

most importantly , why is the linux-schema.json not on repo ?

@divanshu-go divanshu-go changed the title fix: use lang: powershell on windows fix: use lang: cmd on windows Dec 29, 2024
Signed-off-by: divanshu-go <divanshugrover2009@gmail.com>
@louis030195
Copy link
Collaborator

image

it should be tabs suggesting either powershell or cmd on windows like above

@louis030195
Copy link
Collaborator

idk about linux-schema - probably because i dont use linux but u can commit it

@divanshu-go
Copy link
Contributor Author

divanshu-go commented Dec 30, 2024

@louis030195 Do we need to support both Windows Powershell and Windows CMD

My suggestion --> cmd is enough , its easier

In the codebase you are also supporting windows cmd

@divanshu-go
Copy link
Contributor Author

Instead of automatically detecting user's OS why dont we show all the options like this
image

@louis030195 louis030195 marked this pull request as draft January 7, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants