Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taps): update _flatten_record function by adding allow_nan=True in json.dumps #2214

Closed
wants to merge 3 commits into from
Closed

fix(taps): update _flatten_record function by adding allow_nan=True in json.dumps #2214

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcc98f8
Update _flattening.py
dgawlowsky Feb 3, 2024
ed868a1
Merge branch 'meltano:main' into patch-2
dgawlowsky Feb 5, 2024
7d635b3
Merge branch 'main' into patch-2
edgarrmondragon Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion singer_sdk/helpers/_flattening.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ def _flatten_record(
items.append(
(
new_key,
json.dumps(v, use_decimal=True, default=str)
json.dumps(v, use_decimal=True, default=str, allow_nan=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about making this configurable with two initial NaN options (e.g. fail and allow)?

Copy link
Contributor Author

@dgawlowsky dgawlowsky Feb 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a first try, please see move the conversation to #2222 and close this PR if possible.

Edit: I put a draft into the name of the PR as I am still refining the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarrmondragon can you take a look?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarrmondragon please close this PR and see the proposal in #2222

if _should_jsondump_value(k, v, flattened_schema)
else v,
),
Expand Down
Loading