Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Slic #26

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Expose Slic #26

wants to merge 8 commits into from

Conversation

simmimourya
Copy link

No description provided.

Simmi Mourya added 6 commits July 16, 2016 18:01
Add cyvlfeat.slic.slic to 'imports' Section.
gen_extension for 'cyvlfeat.slic.cyslic'.
@menpobot
Copy link

Can one of the admins verify this patch?

@jlaura
Copy link
Contributor

jlaura commented Aug 30, 2017

What is the status on the open PRs from @simmimourya1? The blog post about the functionality looks really good, but the additions appear to be generally awaiting review? Any estimated time until merge and release?

@patricksnape
Copy link
Contributor

Yikes - I've totally fallen behind on this. Since I don't actively use this function, are you able to verify that this outputs expected results?

@braddockcg
Copy link

I just built and tried the simmimourya1:Slic branch.

  1. It seems hard coded to support only single-channel images.

  2. the from cyvlfeat.slic.slic import slic import seems a bit wonky. There was no way to discover this path - when I first imported slic there is no dir or autocompletion that suggests it isn't an empty package.

I'd love to see SLIC support added, but perhaps this needs a little fine-tuning.

@braddockcg
Copy link

Also, output appears corrupted on non-square images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants