Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct signal name when disconnecting from "NameOwnerChanged" #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xhaakon
Copy link
Contributor

@xhaakon xhaakon commented Jun 4, 2014

This is a follow-up to #46.

A disconnectSignal() call with a wrong signal name caused that hook wasn't found and thus kept in QDBusConnectionPrivate::signalHooks forever.

I think it's a good candidate for merging upstream; I'll push the change into Gerrit after your review here.

Assigning a parent to QConnmanServiceInterface instances doesn't help in fixing crash-reporter-autouploader crashes, but I'm proposing this change as well so that the objects are properly destroyed.

Jakub Adam added 2 commits June 4, 2014 15:15
Makes sure they are properly deleted.
A disconnectSignal() call with a wrong signal name caused that hook
wasn't found and thus kept in QDBusConnectionPrivate::signalHooks
forever.
@amccarthy
Copy link

LGTM

@xhaakon
Copy link
Contributor Author

xhaakon commented Jun 5, 2014

Changes in upstream gerrit: 86824, 86825.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants