Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of 'PerfScore' in ResponseApplianceGetDeviceAppliancePerformance #43

Conversation

tommyers-elastic
Copy link

Fixes #42

iamdexterpark and others added 30 commits October 30, 2022 19:28
Manually initiated code generation workflow for Meraki Dashboard OpenAPI specification (v1.26.0)
Manually initiated code generation workflow for Meraki Dashboard OpenAPI specification (v1.27.0)
Separated build docs from usage.
go-retryablehttp added to client.go template to support 429 retries.
Adds retry and backoff logic to HTTP client based on "retry-after" header.
Split Github actions workflow into two jobs:
    1) Version check if a client needs to be generated
    2) Generate new client with git tag/release

Moved templates into .github folder, and deleted the build folder/files.
removed .gitignore from repo.
Adds a new version matching condition to prevent commits such as this one from triggering a client generation build step.
Retrieve a list of organizations.
Update and move the code generator documentation.
fmunozmiranda and others added 27 commits March 14, 2024 13:26
Revert "New main branch SDK doesn't use the intended user agent strin…
Refactor api client to adhere to rate limits
- New main branch SDK doesn't use the intended user agent string format meraki#21
- Incorrect links to documentation in code meraki#23 [Removed]
- API Rate limiting is not handled in client meraki#20
- Refactor api client to adhere to rate limits meraki#25
- `AccessPolicyNumber` was absent in response structs of `ResponseSwitchGetNetworkSwitchAccessPolicy` and `ResponseItemSwitchGetNetworkSwitchAccessPolicies`.
- dashboard-api-go supports now v1.44.1 of Meraki Dashboard API.
- User-agent is now required. Format of string "ApplicationName VendorName".
### Changed
- `ResponseItemNetworksGetNetworkGroupPolicies` add new attribute `Name`.
- `ResponseNetworksGetNetworkSyslogServersServers` change `Port` to string.
- `ResponseNetworksUpdateNetworkSyslogServersServers` change `Port` to string.
### Changed
- `ResponseItemSwitchGetNetworkSwitchAccessPolicies` add new attribute `AccessPolicyNumber`.
- `ResponseSwitchGetNetworkSwitchAccessPolicy` add new attribute `AccessPolicyNumber`.
### Changed
- `ResponseWirelessGetNetworkWirelessSSIDFirewallL3FirewallRulesRules` add new attribute `IpVer`.
- `RequestWirelessUpdateNetworkWirelessSSIDFirewallL3FirewallRulesRules` add new attribute `IpVer`.
### Changed
- Adding request body for `UpdateOrganizationApplianceVpnThirdPartyVpnpeers` in `appliance` settings.
### Changed
- `ResponseWirelessGetNetworkWirelessRfProfiles`is now an array.
### Changed
- Managing different types of values are accepted in `appliance_traffic_shapping`  operations.
- Managing different types of values are accepted in `wireless_ssids_firewall_l7FirewallRules` operations.
### Changed
- Managing different types of values are accepted in `appliance_traffic_shapping`  operations.
- Managing different types of values are accepted in `wireless_ssids_firewall_l7FirewallRules` operations.
### Changed
- update switch.go ResponseItemOrganizationsGetOrganizationDevices.Imei is now a *float64.
- update wireless.go ResponseWirelessGetDeviceWirelessRadioSettingsFiveGhzSettings.ChannelWidth is now a string.
### Changed
- update wireless.go, RequestWirelessUpdateDeviceWirelessRadioSettingsFiveGhzSettings.ChannelWidth is now string.
…ance

The API returns a float, which blows up if you try to unmarshal the response into an int.
This change replaces the type of PerfScore from *int to *float64.
@tommyers-elastic
Copy link
Author

hey @fmunozmiranda, does this PR need updating? what's the reason it was closed? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Device Appliance Performance is now returning float (not int)
7 participants