-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/5950 Architecture: Icon loading in config #6211
base: develop
Are you sure you want to change the base?
Feature/5950 Architecture: Icon loading in config #6211
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6211 +/- ##
==========================================
+ Coverage 4.47% 4.49% +0.01%
==========================================
Files 385 384 -1
Lines 54180 54216 +36
Branches 598 624 +26
==========================================
+ Hits 2425 2436 +11
- Misses 51755 51780 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
📑 Summary
Adding option to load architecture diagram icons via the config using URLs. This enables icon loading when not using the full renderer (e.g. when using the Live Editor or CLI).
Resolves #5950
📏 Design Decisions
UrlIconLoader
parameters (defaults to empty array), loads all icons as defined📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.