PHP 8.4 compatibility (#222)

* Add PHP 8.3 and PHP 8.4 to matrix * Make compatible with PHP 8.4 > MessageBird\Client::__construct(): Implicitly marking parameter $httpClient as nullable is deprecated, the explicit nullable type must be used instead
messagebird · Nov 1, 2024 · 47e7652 · 47e7652
1 parent 1509430
commit 47e7652
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: [ '7.4', '8.0', '8.1', '8.2' ]
+        php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
         stability: [ prefer-stable ]
 
     name: PHP ${{ matrix.php }} - ${{ matrix.stability }}

diff --git a/src/MessageBird/Client.php b/src/MessageBird/Client.php
@@ -147,7 +147,7 @@ class Client
      */
     protected $numbersAPIClient;
 
-    public function __construct(?string $accessKey = null, Common\HttpClient $httpClient = null, array $config = [])
+    public function __construct(?string $accessKey = null, ?Common\HttpClient $httpClient = null, array $config = [])
     {
         if ($httpClient === null) {
             $this->conversationsAPIHttpClient = new Common\HttpClient(