✨ Add stop_configuration_service #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioney
reviewed
Nov 12, 2021
| kill_node(node) | ||
| rospy.loginfo("Stopping node %s" % str(node)) | ||
| rospy.sleep(2) | ||
| self.stop_configuration() |
There was a problem hiding this comment.
wouldn't this fail because the req argument is missing?
maybe create a separate function for the service callback, and then just call the stop_configuration() so it's not conflicting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marioney I want to add the ability to stop configurations.
I want to use this in the case that a FuncDesign has other Functions as dependency. So the dependent Functions are triggered when a FunctionDesign needs it and then when the parent FunctionDesign is reconfigured I want to have the ability to stop the dependent Functions. Something like in the figure below.
Does this make sense?
I tested this code and it seems to work.