Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi!
I was told about this and think its a great project, might also use this myself.
browsing the code I found two pretty simple things:
.toString()
should work for both, numbers and bigints, so we could even upgrade to web3.js 2.0 bigints (if they are even being returned here)Right now I just wanted to fix the type errors. If you prefer strings over bigints or the other way round, let me know and I can set it straight everywhere.
regards
0xAlice
EDIT: I did some more typescript stuff. we're handling bigint differently, I think to be consistent we either have to use strings everywhere or change the schema have the option
{mode: "bigint"}
everywhere.