MBS-13597: Add release filter to label index pages #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was always trying to compare, leading to "argument isn't numeric" warnings.
mwiencek
requested changes
Jan 20, 2025
| @@ -253,6 +266,22 @@ sub find_labels_by_artist | |||
| return $self->c->model('Label')->get_by_ids_sorted_by_name(@$ids); | |||
| } | |||
|
|
|||
| # This might seem stupid, but it helps filtering multi-label releases | |||
| sub find_labels_by_label | |||
There was a problem hiding this comment.
It feels like this belongs more under Data::Label as find_by_release_label, since you can just join with label there and use query_to_list directly.
There was a problem hiding this comment.
I could see that, but that would also seem true of find_labels_by_artist then? Admittedly I was a bit suprised all those things are in Data::Release (find_artist_credits_by_label I would have expected on AC and whatnot).
This extends the release filter from the artist releases page to label index pages, which have very similar lists. Most of the code can be reused, so I moved some into roles. The only real difference with the artist forms are that ACs are taken for all the releases in the label and that "no label exists" is not a filter option for labels, for obvious reasons. Tests added, with very small changes from the artist release ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13597
Problem
We have very useful filter tools for all sort of artist pages that have long and unwieldy tables. Another thing that is long and unwieldy: label pages with sometimes thousands of releases. And we cannot filter those.
Solution
This extends the release filter from the artist releases page to label index pages, which have very similar lists. Most of the code can be reused, so I moved some into roles.
The only real difference with the artist forms are that ACs are taken for all the releases in the label and that "no label exists" is not a filter option for labels, for obvious reasons.
Testing
Tests added, with very small changes from the artist release ones.
While testing this locally I saw we were getting a warning due to the new code to keep ACs when moving around in filters, so I deal with that in the small first commit.