MBS-8500: Add "not by me" filter for collection edit lists #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collection edit lists cannot be filtered, and it can be very hard to find others' edits to review on a collection where you are fairly active yourself as an editor. This could ideally be eventually solved by edit searches, but we are not really near to having collection filters for edit searches. At least for now, having an extra "hide own edits" condition for collections seems like by far the easiest choice, and combines well with the status condition we already have in find_by_collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-8500
Problem
Collection edit lists cannot be filtered, and it can be very hard to find others' edits to review on a collection where you are fairly active yourself as an editor.
Solution
This could ideally be eventually solved by edit searches, but we are not really near to having collection filters for edit searches.
At least for now, having an extra "hide own edits" condition for collections seems like by far the easiest choice, and combines well with the status condition we already have in
find_by_collection.Testing
Manually, with my own private collection I happen to have a lot of edits in. You can always make some edits locally to test though :)