Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ctrl + C message to interactive screens #173

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arishta
Copy link

@arishta arishta commented Jan 18, 2025

-> Added Ctrl + C message to interactive screens

Fixes #154

Please refer the below screenshots for reference:

  1. Inspect screen
Screenshot 2025-01-18 at 12 07 24 PM
  1. Login screen
Screenshot 2025-01-18 at 12 08 21 PM

Similar output exists for other interactive screens.

@arishta
Copy link
Author

arishta commented Jan 18, 2025

@viferga can you please review?

@viferga
Copy link
Member

viferga commented Jan 23, 2025

I want to review this once I achieve to implement the CI for the PRs. I am working on that but this week I had to do some work for GSoC so I stopped this.

In any case, respect to your code. There's something wrong. The idea of this feature is to show it in interfaces like Inspect or the ones that are equivalent to commands like:

watch <something>

or

<something> &> output and then: tail -f output

The idea is that we show this on the interfaces that will not close and will keep forever open. For example in the case of selecting the login, we can just add a new item in the list for "Exit". In another hand, inspect is a good case of the usage of this feature.

Another thing is that this must be shown independently of if it is interactive or not.

Another thing I was interested is to show it at the end of the console, it is normally where it is shown in similar linux like commands, not just a console.log as you did. Maybe something like this:
https://static1.howtogeekimages.com/wordpress/wp-content/uploads/2011/02/banner1.png?q=50&fit=crop&w=1140&h=&dpr=1.5

I am not sure if it is the best idea but that's what I had in mind. What do you think @arishta ?

@viferga viferga marked this pull request as draft January 23, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Any interactive screen should show: Ctrl+C for cancel.
2 participants