Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new methods #12

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Adding new methods #12

wants to merge 15 commits into from

Conversation

blockiosaurus
Copy link
Contributor

Adding getAssets, getAssetProofs, and stubbed in getAssetSignatures.

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
digital-asset-standard-api-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 0:21am

danenbm
danenbm reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@danenbm danenbm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for closing this out! Couple minor nit in README only. Also see some CI failure.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
MarkSackerberg
MarkSackerberg reviewed Jan 21, 2025
View reviewed changes
clients/js/src/decorator.ts Outdated Show resolved Hide resolved
clients/js/src/decorator.ts Outdated Show resolved Hide resolved
clients/js/src/decorator.ts Outdated Show resolved Hide resolved
@MarkSackerberg
Copy link

MarkSackerberg commented Jan 23, 2025 •
edited
Loading

  • fixed the tests except getAssetProofs on devnet (pending MTG-1256) - also pending endpoint update
  • getAssetSignatures works now, but is not perfect. introduced a temporary type DasApiTransactionSignature but would prefer to directly use the TransactionSignature umi type
  • specification json file needs an update for getAssetSignatures
  • readme needs to be extended with new functions

@MarkSackerberg MarkSackerberg mentioned this pull request Jan 28, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkSackerberg MarkSackerberg MarkSackerberg left review comments

@danenbm danenbm danenbm left review comments

@nhanphan nhanphan Awaiting requested review from nhanphan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blockiosaurus @MarkSackerberg @danenbm @febo