[MTG-1007] Updated solana version to 2 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstepanovdev
requested review from
StanChe,
n00m4d,
danenbm and
blockiosaurus
StanChe
reviewed
Dec 2, 2024
kstepanovdev
force-pushed
the
feature/update-solana-version
branch
from
e650711 to
5e31e99
Compare
kstepanovdev
changed the title
kstepanovdev
force-pushed
the
feature/update-solana-version
branch
4 times, most recently
from
c7be7fe to
b273824
Compare
n00m4d
previously approved these changes
Dec 3, 2024
Changed imports respectively; Updated Dockerfile and docs; Changed methods to match the required interface;
kstepanovdev
force-pushed
the
feature/update-solana-version
branch
from
b273824 to
cd2a712
Compare
kstepanovdev
force-pushed
the
feature/update-solana-version
branch
from
494bbee to
ba1dee8
Compare
StanChe
reviewed
Dec 6, 2024
| fi | ||
|
|
||
| if [[ -n $RUST_NIGHTLY_VERSION ]]; then | ||
| nightly_version="$RUST_NIGHTLY_VERSION" | ||
| else | ||
| nightly_version=2022-04-01 | ||
| nightly_version=latest |
There was a problem hiding this comment.
Why not latest rather?
There was a problem hiding this comment.
is latest a valid tag for rustup? Shouldn't these just be stable and nightly?
There was a problem hiding this comment.
That tag is not for rustup. Both nightly and stable are indeed valid toolchain values for a "default" rustup, however, the repo uses images from solanalabs. Those images do not contain toolchains for both versions simultaneously. For instance, the image with nightly was updated one year ago. Therefore, the latest tag is used.
StanChe
approved these changes
Dec 6, 2024
andrii-kl
approved these changes
Dec 24, 2024
danenbm
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for updating is to provide a possibility of running the Solana node with version 2.