Use rove for QC in the ingestor #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intarga
force-pushed
the
rove_integration
branch
2 times, most recently
from
edf95f6 to
389f56a
Compare
Upon further consideration, I think matching obsinn's format like this makes sense. Since we are ingesting live data from weather stations, it's reasonable to expect a station will send observations fromall its params at once with the same timestamp, so we should optimise for this use case
intarga
force-pushed
the
rove_integration
branch
from
389f56a to
bd9be7e
Compare
intarga
commented
Jan 17, 2025
| @@ -27,8 +27,10 @@ quick-xml = { version = "0.35.0", features = [ "serialize", "overlapped-lists" ] | |||
| rand = "0.8.5" | |||
| rand_distr = "0.4.3" | |||
| regex = "1.11.1" | |||
| rove = { git = "https://github.com/metno/rove.git" } | |||
| rove = { git = "https://github.com/metno/rove.git", branch = "lard_fixes" } | |||
| # rove = { git = "https://github.com/metno/rove.git" } | |||
There was a problem hiding this comment.
This needs to be removed before merging
in the future we probably want to have directories like qc_pipelines/periodic and qc_pipelines/consistency, but for now we don't handle that so we just load qc_pipelines/fresh directly
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qc_dataimplementationThis PR integrates rove to perform QC in the ingestor with the current limitations:
I considered verifying the QC output in the integration tests, but decided this was best left for when we implement an API that actually uses them (frost backend?) for now I manually queried the DB after running the integration tests to confirm
qc_usablewas as expected.I restructured the generic
DatumandDataChunkto match their obsinn equivalents. The original idea behind the different structure was that I thought they should be neutral towards different data sources that might structure messages differently, but I realised that the Obsinn structure of clustering by station and timestamp is what makes sense for any source of fresh data, so we should optimise for that.There is a smaller PR of associated fixes in ROVE that should be merged before this one