Increase performance of nested queries #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With nested queries the code was switching on the option so that it could display a custom message. This was causing a massive increase in compilation time as the queries got deeper and wider. In my project we were seeing build times of about 6 minutes, after this change the build went down to about 10-11 seconds. Instead of displaying a custom message, the PPX will now just call out to `Js.Option.getExn`. This might also fix mhallin#61
|
I think we should first understand the cause of the issue (ie how do the differences in output impact compilation performance). Or maybe it’s not differences in the output but the time it takes to compile the make error function |
|
@wokalski My original idea was that the time it takes the PPX to run was the culprit as well. To test this you can go to this repo here and see that the final generated output of the code is the thing that takes a very long time to build using You can see how the above PR changes the final compiled code by comparing the master branch of that graphql-ppx-perf-repo to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With nested queries the code was switching on the option so that it
could display a custom message. This was causing a massive increase in
compilation time as the queries got deeper and wider. In my project we
were seeing build times of about 6 minutes, after this change the build
went down to about 10-11 seconds.
Instead of displaying a custom message, the PPX will now just call out
to
Js.Option.getExn.This might also fix #61