New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial refactoring of `displayz` #3

Draft

shymega wants to merge 24 commits into michidk:main from shymega:refactor

shymega commented Jun 6, 2023 •

edited

Loading

Bump Cargo.lock and dependencies.
Use cfg_attr to expose platform-specific APIs in the platform module, then export with pub use.
Create initial common module for abstracting displays.
Make examples only run on Windows - pending refactoring of Windows backend.
Add lints.

Resolves #2.

shymega force-pushed the refactor branch from c98a2f1 to e7b914c Compare

June 6, 2023 18:06

michidk reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

michidk reviewed

View reviewed changes

src/common/mod.rs Outdated Show resolved Hide resolved

michidk reviewed

View reviewed changes

src/common/mod.rs Outdated Show resolved Hide resolved

michidk reviewed

View reviewed changes

src/common/mod.rs Outdated Show resolved Hide resolved

michidk reviewed

View reviewed changes

src/platforms/macos/mod.rs Outdated Show resolved Hide resolved

shymega commented

View reviewed changes

src/common/mod.rs Outdated Show resolved Hide resolved

shymega force-pushed the refactor branch from 192b70d to 6e42122 Compare

June 6, 2023 22:12

Author

shymega commented Jun 7, 2023

OK, some updates. I've added a note to Resolutions, and wrapped get_edid in an Option.

michidk assigned shymega

michidk added the enhancement label

shymega force-pushed the refactor branch 4 times, most recently from b29f0cc to 3d1318a Compare

June 21, 2023 15:41

shymega added a commit to shymega/displayz that referenced this pull request


          Revert "Add note to Resolutions type about future use"

657ce27

This reverts commit 364433a.

As per @michidk's review comment on PR michidk#3.

shymega added 14 commits

January 11, 2025 19:53


          Initial refactoring of displayz

7fdb09d

- Bump Cargo.lock and dependencies.
- Use `cfg_attr` to expose platform-specific APIs in the `platform`
  module, then export with `pub use`.
- Create initial `common` module for abstracting displays.
- Make examples only run on Windows - pending refactoring of Windows
  backend.
- Add lints.

Resolves michidk#2.

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Improve documentation on common module

db83787

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Fix #[cfg] attributes on Linux platform

e30d6e1

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Fix self-referencing import on Windows platform

c5bb350

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Remove deny lint - as per review

b01cc7c

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Rename get_resolutions to be more clear

1760fb0

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Change Resolution/Position types to struct

25cc00b

(Also, change `usize` to `i32` to allow for negative Positions.
Resolution was changed for consistency)

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Add Linux Wayland/X11 feature flags and optional deps

5c1da8f

This is in preparation for the Linux platform support.

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Clarify get_resolution method in DisplayOutput trait

d688514

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Bump Cargo.lock

5a00d20

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Rename linux to unix to support BSDs/Linux

9c880e2

We now use feature flags to control X11/Wayland exporting.

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Change Wayland dep target to unix target_family

2c5924b

This way we can support the BSDs, as well as Linux. I now know that
FreeBSD supports Wayland.

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Add initial struct for WaylandBackend

a867064

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Add note to Resolutions type about future use

62ef1c2

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>

shymega added 10 commits

January 11, 2025 19:53


          Remove is_focused - move to platform-specific extensions

bffb266

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Wrap get_edid in an Option<T>

97acc1d

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Run cargo-fmt on codebase

56aa7b5

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Revert "Add note to Resolutions type about future use"

a01a9b0

This reverts commit 364433a.

As per @michidk's review comment on PR michidk#3.

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          Add Wayland protocols for Plasma/KDE

9a19c3d

This allows `displayz` to run on KDE, which uses a different set of
protocols to the usual `wlr` crate.

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          refactor: Refactor types into structs, impl Debug/Display

ad544fa

- Change `Resolutions` into tuple struct.
- Impl `Debug` & `Display` for `Position` and `Resolutions`.
- Use `Default` trait for default trait impl.

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          refactor: Change Display type into dyn trait, for generics

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          chore: Remove Windows CLI

d537eb1

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          chore: bump Cargo.lock

61d42e0

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>


          fix: Fix Derives in common/mod.rs

12ec155

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>

shymega force-pushed the refactor branch from 4d3a92f to 12ec155 Compare

January 11, 2025 20:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels