Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http transport client blocking recv #2744

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mapogolions
Copy link

@mapogolions mapogolions commented Dec 30, 2024

I observed that the Recv call gets blocked in the default implementation of the HTTP transport client under certain conditions.

  1. The issue is reproduced in the unit tests introduced in commit 2529793
  2. The commit 9ee16e2 demonstrates a fix for the issue
  3. The commit 182b736 fixes race condition
    The race condition lies in the fact that the http.Response may be associated with the wrong http.Request
    I created a separate branch in my repository to reproduce the race condition. I added a unit test. Here is the link. So, we need to adjust the scope of the lock to resolve the problem.

@mapogolions mapogolions force-pushed the fix-http-transport-client-blocking-recv branch from 5c49d9f to c58c1f6 Compare December 30, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant