Fix http transport client blocking recv #2744
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that the
Recv
call gets blocked in the default implementation of the HTTP transport client under certain conditions.The race condition lies in the fact that the
http.Response
may be associated with the wronghttp.Request
I created a separate branch in my repository to reproduce the race condition. I added a unit test. Here is the link. So, we need to adjust the scope of the lock to resolve the problem.