Fix circular import in ds_transformer.py #5804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sznmelvin
commented
Jul 28, 2024
sznmelvin
commented
- Removed conditional imports of TritonMLP and TritonSelfAttention from module level
- Implemented lazy imports for Triton modules inside init method
- This change aims to resolve circular dependency issues with DeepSpeed Transformer inference
- Removed conditional imports of TritonMLP and TritonSelfAttention from module level - Implemented lazy imports for Triton modules inside __init__ method - This change aims to resolve circular dependency issues with DeepSpeed Transformer inference
loadams
reviewed
Jul 31, 2024
| @@ -13,9 +13,6 @@ | |||
| from deepspeed.accelerator import get_accelerator | |||
| from deepspeed.ops.op_builder import InferenceBuilder | |||
| import deepspeed | |||
| if deepspeed.HAS_TRITON: | |||
There was a problem hiding this comment.
@eonsparks - could you please run the pre-commit formatter (pre-commit run --all-files) to resolve te formatting errors?
loadams
requested changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.