Skip to content

Commit

Permalink
Refactoring of interactive behavior (#122)
Browse files Browse the repository at this point in the history
* Use selectionManager, added measure to selectionId

* Fix word selection

* Add test for selection

* Update dependencies

* Update formattingModel

* Increment visual version

* Add playwright-chromium

* Store selection manager only inside behavior class

* Remove valueSelectionManager

* Remove incoming update options

* Fix test

* Remove animation

* Update build file

---------

Co-authored-by: Iuliia Kulagina <v-ikulagina@microsoft.com>
  • Loading branch information
kullJul and kullJul authored Jun 3, 2024
1 parent a934841 commit 3e94316
Show file tree
Hide file tree
Showing 13 changed files with 2,585 additions and 2,506 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@ name: build

on:
push:
branches: [ main ]
branches: [ main, dev, certification]
pull_request:
branches: [ main ]
branches: [ main, dev, certification ]

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [18.x, 20.x]

steps:
- uses: actions/checkout@v2
Expand All @@ -23,6 +23,8 @@ jobs:
- run: npm audit
continue-on-error: true

- run: npm outdated
continue-on-error: true
- run: npm ci

- run: npm run eslint --if-present
Expand All @@ -31,6 +33,6 @@ jobs:

- run: npm run package

- run: npm run test
- run: npm test
env:
CI: true
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 2.3.0.0
* API v5.9.0
* Use selectionManager for interactive behavior
* Fix clear selection bug
* Add bookmark support
* Update dependencies and fix audit vulnerabilities

## 2.2.0
* API v5.4.0
* Fixed bug with instantiation of the SelectingManager class
Expand Down
2 changes: 1 addition & 1 deletion karma.conf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const testRecursivePath = "test/visualTest.ts";
const srcOriginalRecursivePath = "src/**/*.ts";
const coverageFolder = "coverage";

process.env.CHROME_BIN = require("playwright").chromium.executablePath();
process.env.CHROME_BIN = require("playwright-chromium").chromium.executablePath();

module.exports = (config) => {
config.set({
Expand Down
Loading

0 comments on commit 3e94316

Please sign in to comment.