-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-33026/feat: unit converter, improve data units #33563
base: main
Are you sure you want to change the base?
Conversation
@david-hankinson please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
New to this project and looking for feedback from a draft PR
Steps taken to understand the issue:
Built the tool locally
Replicated the issue
What I understand so far:
This isn't my usual type of project, usually work on cloud infra as code projects. I have started to make amendments here so wanted to start the conversation with you now to avoid going down blind alleys. The method i've edited uses the UnitsNet for conversion and this can handle the different standards for data units.
I would also be interested to know how you've setup your machine for formatting/linting and general shift left tools.
Questions:
Validation Steps Performed
I haven't ran any tests yet, although after this discussion I can move onto that