Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boost-math to 1.86.0. #4890

Closed
wants to merge 1 commit into from
Closed

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Aug 15, 2024

@fsb4000 fsb4000 requested a review from a team as a code owner August 15, 2024 01:35
@fsb4000 fsb4000 marked this pull request as draft August 15, 2024 01:49
@fsb4000
Copy link
Contributor Author

fsb4000 commented Aug 15, 2024

FAILED: stl/CMakeFiles/msvcp_2d_objects.dir/src/special_math.cpp.obj 
C:\PROGRA~1\MICROS~1\2022\Preview\VC\Tools\MSVC\1441~1.340\bin\Hostx64\x64\cl.exe  /nologo /TP -DBOOST_MATH_STANDALONE=1 -DNTDDI_VERSION=NTDDI_WIN10_NI -DSTRICT -DWIN32_LEAN_AND_MEAN -D_ALLOW_ITERATOR_DEBUG_LEVEL_MISMATCH -D_AMD64_ -D_BUILDING_SATELLITE_2 -D_CRTBLD -D_CRT_STDIO_ARBITRARY_WIDE_SPECIFIERS -D_DEBUG -D_DLL -D_HAS_OLD_IOSTREAMS_MEMBERS=1 -D_STL_WIN32_WINNT=0x0501 -D_VCRT_ALLOW_INTERNALS -D_VCRT_WIN32_WINNT=0x0501 -D_WIN32_WINNT=0x0A00 -I"C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.41.34021\crt\src\vcruntime" -ID:\a\_work\1\s\stl\inc -ID:\a\_work\1\s\boost-math\include -Z7 /analyze:autolog- /wd6553 /WX /Gy /diagnostics:caret /W4 /w14265 /w15038 /fastfail /guard:cf /Zp8 /std:c++latest /permissive- /Zc:preprocessor /Zc:threadSafeInit- /Zl /EHsc /Od /showIncludes /Fostl\CMakeFiles\msvcp_2d_objects.dir\src\special_math.cpp.obj /Fdstl\CMakeFiles\msvcp_2d_objects.dir\ /FS -c D:\a\_work\1\s\stl\src\special_math.cpp
D:\a\_work\1\s\boost-math\include\boost\math\special_functions\detail\bessel_ik.hpp(417) : error C2220: the following warning is treated as an error
D:\a\_work\1\s\boost-math\include\boost\math\special_functions\detail\bessel_ik.hpp(417) : warning C4701: potentially uninitialized local variable 'n' used
D:\a\_work\1\s\boost-math\include\boost\math\special_functions\detail\bessel_ik.hpp(417) : warning C4701: potentially uninitialized local variable 'u' used
D:\a\_work\1\s\boost-math\include\boost\math\special_functions\detail\bessel_ik.hpp(417) : warning C4701: potentially uninitialized local variable 'n' used
D:\a\_work\1\s\boost-math\include\boost\math\special_functions\detail\bessel_ik.hpp(417) : warning C4701: potentially uninitialized local variable 'u' used

It seems we can send a patch to boost-math and skip the 1.86.0 version and will use 1.87.0 later.
I will prepare a patch after work.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Aug 15, 2024
@fsb4000
Copy link
Contributor Author

fsb4000 commented Aug 16, 2024

I've created: boostorg/math#1181

@fsb4000 fsb4000 closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants