Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main_0.29] Cherry-pick: New method for separator hiding (#2068) #2070

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

sophialee0416
Copy link
Contributor

@sophialee0416 sophialee0416 commented Jul 17, 2024

(cherry picked from commit 30b8885)

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

(how the change was tested, including both manual and automated tests)

Visual Verification
Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@sophialee0416 sophialee0416 requested a review from a team as a code owner July 17, 2024 21:07
@sophialee0416 sophialee0416 enabled auto-merge (squash) July 17, 2024 21:11
@sophialee0416 sophialee0416 mentioned this pull request Jul 17, 2024
12 tasks
@sophialee0416 sophialee0416 merged commit cbb3677 into microsoft:main_0.29 Jul 17, 2024
7 checks passed
@sophialee0416 sophialee0416 deleted the sople/cp_tvc branch July 18, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants