Ensure TableViewHeaderFooterView has a themed default text color and font style #2076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Issue: Attributed strings in the
TableViewHeaderFooterView
were showing as black if a foreground color attribute was not provided.Root Cause: The attributed text color will default to the
textColor
of theUITextView
. According to the Apple documentation, the default text color for aUITextView
is black, explaining why we were seeing the text show as black in both light and dark modesFix: Check if an attributed foreground color is provided with string. If not, apply the fluent theme text color. Also do the same thing for font.
Binary change
Total increase: 19,560 bytes
Total decrease: 0 bytes
Full breakdown
Verification
Visual Verification
Before change, without attributes applied to string:
After change, without attributes applied to string:
After change, with attributes applied to string:
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow